👔 Add newsPress tag to iscnPayload #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuroraHuang22
temporarily deployed
to
production
GitHub Actions
Inactive
AuroraHuang22
force-pushed
the
feature/news-press
branch
from
586dbb7 to
0f353ca
Compare
AuroraHuang22
temporarily deployed
to
production
GitHub Actions
Inactive
AuroraHuang22
changed the title
nwingt
approved these changes
Oct 2, 2024
williamchong
reviewed
Oct 2, 2024
| @@ -287,8 +286,11 @@ export default class FetchIndex extends Vue { | |||
| publisher, | |||
| type = 'CreativeWork', | |||
| } = this.iscnData | |||
| let { description = '' } = this.iscnData | |||
| let { description = '', keywords = '' } = this.iscnData | |||
There was a problem hiding this comment.
Will this duplicate with https://github.com/likecoin/app-like-co/pull/486/files?
Should we check if NewsPress already exists?
There was a problem hiding this comment.
williamchong
requested changes
Oct 19, 2024
pages/nft/url/index.vue
Outdated
| description = this.truncate(description, 200) | ||
| if (!keywords.includes('NewsPress')) { |
There was a problem hiding this comment.
Suggested change
| if (!keywords.includes('NewsPress')) { | |
| if (this.isNewsPress && !keywords.includes('NewsPress')) { |
We still need to check this.isNewsPress?
There was a problem hiding this comment.
AuroraHuang22
force-pushed
the
feature/news-press
branch
from
f5ac429 to
f4a8803
Compare
williamchong
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.