Skip to content

Commit

Permalink
Add CLI integ tests.
Browse files Browse the repository at this point in the history
  • Loading branch information
nsthorat committed Dec 19, 2023
1 parent 91a1b28 commit 196e998
Show file tree
Hide file tree
Showing 4 changed files with 39 additions and 0 deletions.
12 changes: 12 additions & 0 deletions .github/workflows/cli.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
name: CLI

jobs:
run_tests:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- name: Test CLI
run: |
chmod +x ./integration_tests/run_integration_tests.sh
./integration_tests/run_integration_tests.sh
shell: bash
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ dist/
# Data to ignore.
/data
demo_data/
# Artifacts from integration test data.
test_data/

# Ignore pickled concept models.
data/concept/**/*.pkl
Expand Down
24 changes: 24 additions & 0 deletions integration_tests/run_integration_tests.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Bash-based integration tests for lilac.

set -e # Fail if any of the commands below fail.

# Make sure the CLI succeeds for test_data.
mkdir -p test_data
touch test_data/lilac.yml

FREE_PORT=$(python -c 'import socket; s=socket.socket(); s.bind(("", 0)); print(s.getsockname()[1]); s.close()');


poetry run lilac start test_data --port $FREE_PORT &
pid="$!" # need to get the pid of the vlc process.
sleep 4

# Make a test request using curl
curl --fail "http://localhost:$FREE_PORT/"

# Save curl's exit code (-f option causes it to return one on HTTP errors)
curl_exit_code=$?

kill $pid

exit 0
1 change: 1 addition & 0 deletions scripts/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ set -e

./scripts/test_ts.sh
./scripts/test_py.sh
./integration_tests/run_integration_tests.sh

0 comments on commit 196e998

Please sign in to comment.