Fix ll.start_server() and add a test for full end-to-end server sta…

…rtup (#984)
lilacai · Dec 19, 2023 · 8f8f486 · 8f8f486
1 parent 2bf7879
commit 8f8f486
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/lilac/server.py b/lilac/server.py
@@ -201,8 +201,11 @@ def __init__(self, config: Config) -> None:
     super().__init__(config)
 
     def run() -> None:
-      loop = asyncio.get_event_loop()
-      loop.run_until_complete(self.serve())
+      try:
+        loop = asyncio.get_event_loop()
+        loop.run_until_complete(self.serve())
+      except RuntimeError:
+        self.run()
 
     self.thread = Thread(target=run)
 

diff --git a/lilac/server_test.py b/lilac/server_test.py
@@ -1,5 +1,6 @@
 """Test our public REST API."""
 import os
+from time import sleep
 
 from fastapi.testclient import TestClient
 from pytest_mock import MockerFixture
@@ -12,7 +13,7 @@
   UserInfo,
   get_session_user,
 )
-from .server import app
+from .server import app, start_server, stop_server
 
 client = TestClient(app)
 
@@ -161,3 +162,9 @@ def user() -> UserInfo:
     ),
     auth_enabled=True,
   )
+
+
+def test_start_and_stop_server() -> None:
+  start_server()
+  sleep(1)
+  stop_server()