Fix issue where by default a long media doesnt take up the full screen #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmilkov
approved these changes
Feb 2, 2024
|
This is done, but github does not like to load on airplanes.
…On Fri, Feb 2, 2024 at 9:40 AM Daniel Smilkov ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In web/blueprint/src/lib/components/datasetView/DatasetLoadingPage.svelte
<#1159 (comment)>:
> @@ -162,6 +162,7 @@
totalNumRows={$firstRow?.data?.total_num_rows}
{mediaFields}
{highlightedFields}
+ datasetViewHeight={320}
worth testing add a new dataset to make sure this didn't mess something
------------------------------
In web/blueprint/src/lib/components/datasetView/ItemMediaDiff.svelte
<#1159 (comment)>:
> @@ -106,6 +119,9 @@
</div>
</div>
<div class="editor-container" bind:this={editorContainer} />
+ {#if isFetching}
since the div below is empty (no children), worth a comment about what it
displays on screen
—
Reply to this email directly, view it on GitHub
<#1159 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIMXTIRCOAZ3FPWIJEQNXTYRT3HLAVCNFSM6AAAAABCVVHSPSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNJZGQYTCNJSGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://lilacai-nikhil-staging.hf.space/datasets#local/mosaic-chat-v2&rowId=%22000006e20ceb477f889e297c22f4e2f2%22