Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format selectors to the compute clusters UI. #1185

Merged
merged 7 commits into from
Feb 17, 2024
Merged

Add format selectors to the compute clusters UI. #1185

merged 7 commits into from
Feb 17, 2024

Conversation

@lilacai lilacai deleted a comment from review-notebook-app bot Feb 15, 2024
Copy link
Contributor

@brilee brilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the one comment about autosuggesting a column name for sharegpt selectors

@nsthorat
Copy link
Contributor Author

done!

Copy link
Collaborator

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceee

<Toggle labelA={'False'} labelB={'True'} bind:toggled={options.overwrite} hideLabel />
<div>
<div class="label text-s mb-2 font-medium text-gray-700">
{outputColumnRequired ? '*' : ''} Output column {!outputColumnRequired
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since output column is optional, is it possible to populate the input box with the default column name? (informs the person where results will end up)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@nsthorat nsthorat merged commit 8e7418d into main Feb 17, 2024
4 checks passed
@nsthorat nsthorat deleted the nik-c-ui branch February 17, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants