Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snippeting and fix some UI bugs. #421

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Add snippeting and fix some UI bugs. #421

merged 2 commits into from
Jul 5, 2023

Conversation

nsthorat
Copy link
Contributor

@nsthorat nsthorat commented Jul 5, 2023

  • Snippets now are chosen by determining a subset of spans that cross the .5 threshold. Then we sort the rest, and add them until we reach the budget (~500 characters).
  • Fix the bug where scrolling the item container keeps the hover spans around.
  • Make the right hand side have max height = the size of the media container. Now it scrolls. If it is less than the height, it is sticky.
  • Remove metadata that is a child of a span. It gets rendered with the media.
snippets.mp4

@nsthorat nsthorat requested a review from dsmilkov July 5, 2023 20:15
@nsthorat nsthorat merged commit 50ea418 into main Jul 5, 2023
2 checks passed
@nsthorat nsthorat deleted the nik-snippets branch July 5, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants