Deploy to HF: upload dataset via spaces & bug fixes for the working demo. #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsthorat
changed the title
dsmilkov
reviewed
Jul 10, 2023
| @@ -12,12 +12,6 @@ WORKDIR /server | |||
| COPY requirements.txt . | |||
| RUN pip install --no-cache-dir -r requirements.txt | |||
|
|
|||
There was a problem hiding this comment.
can you add -k uvicorn.workers.UvicornWorker to the uvicorn line 30, (worth testing locally). See https://www.uvicorn.org/deployment/
dsmilkov
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deploy_hf: Uploads the data to the huggingface space. The server then checks whether theHF_DATA_FROM_SPACEenvironment flag is set, and downloads data before booting up the server. This will be set from the UI (as mentioned in instructions).Demo: https://huggingface.co/spaces/lilacai/nikhil_staging