Add an environment flag for LILAC_AUTH_ENABLED and turn off features. #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsthorat
changed the title
nsthorat
changed the title
dsmilkov
approved these changes
Jul 18, 2023
| @@ -6,6 +6,10 @@ LILAC_DATA_PATH=./data | |||
| # Set to 1 for duckdb to use views instead of materialized tables (lower memory usage, but slower). | |||
| DUCKDB_USE_VIEWS=0 | |||
|
|
|||
| # Set to true to enable read-only mode, disabling the ability to add datasets & compute dataset | |||
| # signals. | |||
| # LILAC_AUTH_ENABLED=true | |||
There was a problem hiding this comment.
add this variable in .env.demo in deploy_hf.py ?
There was a problem hiding this comment.
Didn't do this yet on purpose -- for our staging demos I don't want this bit on, and I'm not sure yet if this should be controlled only through the UI (since it's nice for discoverability when forking)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features turned off with readonly:
Features not yet turned off (will do this once I figure out auth in HF):
Readonly demo: https://huggingface.co/spaces/lilacai/nikhil_staging