-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Google OAuth Login flow. #459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!
.env
Outdated
# The client secret of the above client. | ||
# GOOGLE_CLIENT_SECRET= | ||
# A random string for oauth sessions. | ||
# LILAC_OAUTH_SECRET_KEY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add =
at the end for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
src/router_google_login.py
Outdated
@@ -0,0 +1,62 @@ | |||
"""Router for tasks.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update pydoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Demo: https://huggingface.co/spaces/lilacai/nikhil_staging
We use Google login to authenticate the user. This uses the OAuth2 flow where a user clicks /login, redirects to /auth which sets a cookie, and redirects back to the app.