Open
Conversation
It currently doesn't work. This is a checkpoint while I try and rip out registrationutils
…trationUtils fix: now works with newer versions of Soul Fire'd fix: nonliving entities (items, boats, etc.) can now be hurt/destroyed by bonfires
undo version bump (not my responsibility) adds runs (from neoforge) to gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #113
Nonliving entities (items, boats, etc.) weren't hurt by bonfires.
Truth be told I had most of these changes already lying around when you responded on the issue. Took the time today to port them to 1.20.4 as well and will link from that PR to here.
Details
Bump Soul Fire'd, gradle, loom and foojay resolver
Rip out RegistrationUtils ('cherry'-picked a commit on the 1.20.4 branch, though still using IWoodType)
Call the common Soul Fire'd function, no more platform service. (Still separate class)
Concerns
Breaks WoodGood (EveryCompat) but I've checked and it really only needs a recompilation with this set of changes which is actually why the 'cherry'-pick isn't as faithful as can be.