fix: Fix MagmaIsomorphism method (#19)

* fix: Fix MagmaIsomorphism
limakzi · Jul 14, 2024 · a7453af · a7453af
1 parent d2245b7
commit a7453af
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib/utils.gi b/lib/utils.gi
@@ -23,7 +23,7 @@ InstallGlobalFunction(MagmaIsomorphism,
     function(M, N)
         local psi, n, p, m, elms;
         if Size(M) <> Size(N) then
-            return false;
+            return fail;
         fi;
 
         n := Size(M);
@@ -46,7 +46,7 @@ InstallGlobalFunction(MagmaAntiisomorphism,
         local psi, n, p, m, elms;
 
         if Size(M) <> Size(N) then
-            return false;
+            return fail;
         fi;
 
         n := Size(M);

diff --git a/tst/test_utils.tst b/tst/test_utils.tst
@@ -69,5 +69,15 @@ gap> Filtered(AllSmallAntimagmas(2), M -> IsCancellative(M) );
 gap> Filtered(AllSmallAntimagmas(3), M -> IsCancellative(M) );
 [ ]
 
+gap> Ms_2 := AllSmallAntimagmas(2);;
+
+gap> Ms_3 := AllSmallAntimagmas(3);;
+
+gap> List(Cartesian(Ms_2, Ms_3), M -> IsMagmaIsomorphic(M[1], M[2]));
+[ false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false ]
+
+gap> List(Cartesian(Ms_2, Ms_3), M -> MagmaIsomorphism(M[1], M[2]));
+[ fail, fail, fail, fail, fail, fail, fail, fail, fail, fail, fail, fail, fail, fail, fail, fail, fail, fail, fail, fail ]
+
 gap> STOP_TEST( "test_utils.tst" );