fix: Fix missing local-variable (#6)

* fix: Fix missing local-variable * feat: Add more tests and transposed method
limakzi · Apr 2, 2024 · a99471f · a99471f
1 parent d386d7d
commit a99471f
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 1 deletion.
diff --git a/lib/utils.gd b/lib/utils.gd
@@ -27,6 +27,11 @@ DeclareGlobalFunction( "IsMagmaIsomorphic" );
 #!  are anti-isomorphic.
 DeclareGlobalFunction( "IsMagmaAntiisomorphic" );
 
+#! @Arguments [M]
+#! @Description
+#!  generates transposed magma <A>M</A> (a string) 
+DeclareGlobalFunction( "TransposedMagma" );
+
 
 #! @Arguments [M]
 #! @Description

diff --git a/lib/utils.gi b/lib/utils.gi
@@ -9,6 +9,11 @@ InstallGlobalFunction(IsAntiassociative,
         return true;
 end);
 
+InstallGlobalFunction(TransposedMagma,
+    function(M)
+        return MagmaByMultiplicationTable(TransposedMat(MultiplicationTable(M)));
+end);
+
 InstallGlobalFunction(MagmaIsomorphism,
     function(M, N)
         local psi, n, p, m, elms;
@@ -71,7 +76,7 @@ end);
 
 InstallGlobalFunction(HasPropertyA3,
     function(M)
-        local partitions, s, p, ns, rows_cartesian, bool_across_values;
+        local partitions, s, p, ns, rows_cartesian, bool_across_values, bool_across_partitions;
         ns := GeneratorsOfMagma(M);
         for s in [ 2 .. Size(M) ] do
             partitions := PartitionsSet(ns, s);

diff --git a/tst/test_utils_hasproperty_a3.tst b/tst/test_utils_hasproperty_a3.tst
@@ -0,0 +1,13 @@
+gap> START_TEST("smallantimagmas: test_utils_hasproperty_a3.tst");
+
+gap> ForAll(AllSmallAntimagmas(2), M -> HasPropertyA3(M) or HasPropertyA3( TransposedMagma(M) ) );
+true
+
+gap> ForAll(AllSmallAntimagmas(3), M -> HasPropertyA3(M) or HasPropertyA3( TransposedMagma(M) ) );
+true
+
+gap> ForAny(AllSmallAntimagmas(4), M -> not (HasPropertyA3(M) or HasPropertyA3( TransposedMagma(M) ) ) );
+true
+
+gap> STOP_TEST( "test_utils_hasproperty_a3.tst" );
+