Update pp calculations #69
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the pp calculations in osuplus to use Francesco149/ojsama, which is more up to date than osuck, but not up to date with the most recent pp changes. There’s another library that’s fully up to date, but osuplus would need some bigger changes before we can switch to that, so let me know and we can discuss.
ojsama only supports standard mode, but so does osuck, so I’ve replaced the osuck code entirely. Note that ojsama doesn’t use
@require, because it exports everything in an “osu” object, which the site also uses for its own stuff.doPpcalc is basically the interesting part. It replaces the old getPpCalc, and it handles downloading the beatmap file, parsing it, and calculating pp and pp if full combo.
As a bonus, this makes pp calculations for multiple plays of the same beatmap instant.