Provide a CalDAV based implementation for EventAttendanceRepository #1498
+2,590
−714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibenwa
reviewed
Feb 3, 2025
Comment on lines
+102
to
+113
| if (partStat.equals(PartStat.ACCEPTED)) { | ||
| return Optional.of(Accepted); | ||
| } else if (partStat.equals(PartStat.DECLINED)) { | ||
| return Optional.of(Declined); | ||
| } else if (partStat.equals(PartStat.NEEDS_ACTION)) { | ||
| return Optional.of(NeedsAction); | ||
| } else if (partStat.equals(PartStat.TENTATIVE)) { | ||
| return Optional.of(Tentative); | ||
| } else { | ||
| LOGGER.trace("Unable to map PartStat '{}' to AttendanceStatus.", partStat); | ||
| return Optional.empty(); | ||
| } |
chibenwa
reviewed
Feb 3, 2025
Comment on lines
+129
to
+130
| AttendanceStatus.fromCalendarAttendeeParticipationStatus(p).orElseThrow()) | ||
| )).getOrElse(() -> CalendarEventAttendanceResults$.MODULE$.notFound(blobId)); |
There was a problem hiding this comment.
AttendanceStatus.fromCalendarAttendeeParticipationStatus(p).orElseThrow())))
.getOrElse(() -> CalendarEventAttendanceResults$.MODULE$.notFound(blobId));
chibenwa
reviewed
Feb 3, 2025
Comment on lines
+106
to
+117
| if (events.isEmpty()) { | ||
| LOGGER.debug(""" | ||
| No VEvents found in calendar object. | ||
| Returning empty attendance results. | ||
| """); | ||
| return CalendarEventAttendanceResults.empty(); | ||
| } else { | ||
| LOGGER.debug(""" | ||
| Expected exactly one VEvent, but found {} entries. Using the first VEvent. | ||
| This may indicate unhandled recurrent events or a malformed calendar object. | ||
| VEvents: {} | ||
| """, events.size(), events); |
chibenwa
reviewed
Feb 3, 2025
| return Flux.fromIterable(JavaConverters.seqAsJavaList(calendarEventBlobIds.value())) | ||
| .flatMap(blobId -> getEventUid(blobId.value(), systemMailboxSession) | ||
| .flatMap(eventUid -> | ||
| toDavUser(username) |
There was a problem hiding this comment.
Please manage to resolve the dav user only once and not fot each event Uid
chibenwa
reviewed
Feb 3, 2025
Comment on lines
+147
to
+152
| public Publisher<CalendarEventReplyResults> setAttendanceStatus(Username username, | ||
| AttendanceStatus attendanceStatus, | ||
| BlobIds eventBlobIds, | ||
| Optional<LanguageLocation> maybePreferredLanguage) { | ||
| return null; | ||
| } |
chibenwa
reviewed
Feb 3, 2025
...l-third-party/openpaas/src/main/java/com/linagora/tmail/CalDavEventAttendanceRepository.java
Show resolved
Hide resolved
chibenwa
reviewed
Feb 3, 2025
| .reduce(CalendarEventAttendanceResults$.MODULE$.empty(), CalendarEventAttendanceResults$.MODULE$::merge); | ||
| } | ||
|
|
||
| private CalendarEventAttendanceResults getAttendanceStatusFromCalendarObject(BlobId blobId, |
There was a problem hiding this comment.
This method is long. Prease do use method extraction
chibenwa
reviewed
Feb 3, 2025
| return extractMessageId(blobId) | ||
| .flatMap(messageId -> | ||
| Mono.fromDirect( | ||
| messageIdManager.getMessagesReactive(List.of(messageId), FetchGroup.MINIMAL, mailboxSession))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1329