Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POC integration test for Mobile with Patrol #2953

Open
wants to merge 14 commits into
base: sprint_25_flutter_3_22_2
Choose a base branch
from
Open

POC integration test for Mobile with Patrol #2953

wants to merge 14 commits into from

Conversation

hoangdat
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/2953.

@hoangdat hoangdat mentioned this pull request Jun 21, 2024
Open
5 tasks
@tddang-linagora tddang-linagora changed the base branch from refactor to sprint_25_flutter_3_22_2 July 15, 2024 08:24
hoangdat
hoangdat commented Jul 23, 2024
View reviewed changes
.fvmrc Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@hoangdat hoangdat mentioned this pull request Jul 23, 2024
Open
8 tasks
@hoangdat hoangdat changed the title [WIP] POC integration test [WIP] POC integration test for Mobile with Patrol Jul 23, 2024
@tddang-linagora tddang-linagora changed the title [WIP] POC integration test for Mobile with Patrol POC integration test for Mobile with Patrol Jul 23, 2024
dab246
dab246 reviewed Jul 23, 2024
View reviewed changes
pubspec.yaml Show resolved Hide resolved
dab246
dab246 reviewed Jul 23, 2024
View reviewed changes
pubspec.yaml Outdated Show resolved Hide resolved
dab246
dab246 reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should create a patrol folder in test or name the test file containing patrol for easy management later.

@tddang-linagora
Copy link
Contributor

We should create a patrol folder in test or name the test file containing patrol for easy management later.

Integration test should explicitly be inside integration_test folder. Both Flutter & Patrol suggest so.

@dab246
Copy link
Member

dab246 commented Jul 23, 2024

We should create a patrol folder in test or name the test file containing patrol for easy management later.

Integration test should explicitly be inside integration_test folder. Both Flutter & Patrol suggest so.

It still belongs to integration_test. We have many tools to write integration_test. and now you are using Patrol so we should identify it separately. Maybe we will use other tools for integration_test

@hoangdat
Copy link
Member Author

Maybe we will use other tools for integration_test

I think no other tools, only patrol to work with integration_test at the moment, if we want to change tool, need to change all the tests too

hoangdat
hoangdat commented Aug 16, 2024
View reviewed changes
integration_test/test_bundle.dart
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should ignore it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tddang-linagora tddang-linagora tddang-linagora approved these changes

@dab246 dab246 Awaiting requested review from dab246

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hoangdat @tddang-linagora @dab246 @tk-nguyen