Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hot fix some bug UI #2961

Open
wants to merge 3 commits into
base: refactor
Choose a base branch
from
Open

Hot fix some bug UI #2961

wants to merge 3 commits into from
+209 −203

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Jun 27, 2024

Issue

  • Alignment receive time in email view
  • Excess space when subject is empty
  • The platformViewRegistry in dart:ui is deprecated

Resolved

  • Alignment receive time in email view:
Before After
  • Excess space when subject is empty:
Before After
subject -old Screenshot 2024-06-27 at 10 51 57
Screen.Recording.2024-06-27.at.10.52.29.mov

@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/2961.

@tddang-linagora
Copy link
Contributor

tddang-linagora commented Jun 27, 2024 •
edited by dab246
Loading

  • Test focus transitioning when pressing Tab on keyboard (Due to code change in relevant functionality)

@dab246
Copy link
Member Author

dab246 commented Jun 27, 2024

  • Test focus transitioning when pressing Tab on keyboard (Due to code change in relevant functionality)

Work fine.

Screen.Recording.2024-06-27.at.15.18.04.mov

@dab246 dab246 changed the base branch from refactor to sprint_25_flutter_3_22_2 July 18, 2024 03:56
@dab246 dab246 changed the base branch from sprint_25_flutter_3_22_2 to refactor August 19, 2024 03:29
@dab246
Copy link
Member Author

dab246 commented Aug 19, 2024 •
edited
Loading

Rebase completed. Please review again @hoangdat

@hoangdat
Copy link
Member

Please add a small issue:

  • remove blink blink of next - previous button in Email View

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tddang-linagora tddang-linagora tddang-linagora approved these changes

@hoangdat hoangdat Awaiting requested review from hoangdat

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dab246 @tddang-linagora @hoangdat