Skip to content

TF-3246 Fix PDF viewer scrollbar not working #3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

TF-3246 Fix PDF viewer scrollbar not working #3343

wants to merge 1 commit into from

Conversation

tddang-linagora
Copy link
Collaborator

Issue

Demo

Screen.Recording.2024-12-11.at.15.46.52.mov

@tddang-linagora tddang-linagora self-assigned this Dec 11, 2024
@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3343.

dab246
dab246 reviewed Dec 11, 2024
View reviewed changes
@dab246
Copy link
Member

dab246 commented Dec 11, 2024 •
edited by tddang-linagora
Loading

  • Html view is closed when clicking on content space
demo-click-close-view.mov
  • The content size seems bigger than before, can we improve it?
Screen.Recording.2024-12-11.at.16.32.35.mov

dab246
dab246 reviewed Dec 13, 2024
View reviewed changes
dab246
dab246 reviewed Dec 13, 2024
View reviewed changes
dab246
dab246 reviewed Dec 13, 2024
View reviewed changes
dab246
dab246 reviewed Dec 13, 2024
View reviewed changes
@dab246
Copy link
Member

dab246 commented Dec 13, 2024 •
edited by tddang-linagora
Loading

  • Current page value is incorrect when zooming out and scrolling
Screen.Recording.2024-12-13.at.15.32.42.mov

@tddang-linagora
Copy link
Collaborator Author

Current page value is incorrect when zooming out and scrolling

Screen.Recording.2024-12-13.at.16.58.22.mov

@dab246
Copy link
Member

dab246 commented Dec 16, 2024 •
edited by tddang-linagora
Loading

Current page value is incorrect when zooming out and scrolling

  • Page value still incorrect when make zooming out or zooming in then scrolling
Screen.Recording.2024-12-16.at.13.59.31.mov

dab246
dab246 previously approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment •
edited by tddang-linagora
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please rebase it

@tddang-linagora tddang-linagora force-pushed the fixbug/TF-3246-pdf-viewer-scrollbar branch from 8e47e6d to 43a0e43 Compare December 16, 2024 09:32
@hoangdat hoangdat dismissed dab246’s stale review February 5, 2025 11:06

The merge-base changed after approval.

@tddang-linagora tddang-linagora force-pushed the fixbug/TF-3246-pdf-viewer-scrollbar branch from 43a0e43 to 9856ffd Compare February 24, 2025 08:05
@hoangdat
Copy link
Member

hoangdat commented Mar 3, 2025

@tddang-linagora , please re-check, can not run well with 3.24.5

Target dart2js failed: ProcessException: Process exited abnormally with exit code 1:
Error: Couldn't resolve the package 'pdf_render' in 'package:pdf_render/src/web/pdf_render_web_plugin.dart'.
.dart_tool/flutter_build/981f079fc03a22a47b0503d6eea621f8/web_plugin_registrant.dart:25:8:
Error: Not found: 'package:pdf_render/src/web/pdf_render_web_plugin.dart'
import 'package:pdf_render/src/web/pdf_render_web_plugin.dart';

@tddang-linagora
Copy link
Collaborator Author

Test in #3495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dab246 dab246 dab246 left review comments

@hoangdat hoangdat Awaiting requested review from hoangdat

Assignees

@tddang-linagora tddang-linagora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tddang-linagora @dab246 @hoangdat