Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Drew Oldag <47493171+drewoldag@users.noreply.github.com>
  • Loading branch information
mtauraso and drewoldag authored Nov 16, 2024
1 parent ce1cf2b commit 7ab428e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/fibad/data_sets/hsc_data_set.py
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@ def _rebuild_manifest(self, config):
column_names = Downloader.MANIFEST_COLUMN_NAMES
columns = {column_name: [] for column_name in column_names}

Check warning on line 645 in src/fibad/data_sets/hsc_data_set.py

View check run for this annotation

Codecov / codecov/patch

src/fibad/data_sets/hsc_data_set.py#L644-L645

Added lines #L644 - L645 were not covered by tests

# These we vary every object and must be implemented below
# These will vary every object and must be implemented below
dynamic_column_names = ["object_id", "filter", "dim", "tract", "ra", "dec", "filename"]

Check warning on line 648 in src/fibad/data_sets/hsc_data_set.py

View check run for this annotation

Codecov / codecov/patch

src/fibad/data_sets/hsc_data_set.py#L648

Added line #L648 was not covered by tests
# These are pulled from config ("sw", "sh", "rerun", "type", "image", "mask", and "variance")
static_column_names = [name for name in column_names if name not in dynamic_column_names]

Check warning on line 650 in src/fibad/data_sets/hsc_data_set.py

View check run for this annotation

Codecov / codecov/patch

src/fibad/data_sets/hsc_data_set.py#L650

Added line #L650 was not covered by tests
Expand Down

0 comments on commit 7ab428e

Please sign in to comment.