Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "svg-compressed" to create a simple classic QR Code with compressed file size. Allow execution from a development environment. #342

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

johnkw
Copy link

@johnkw johnkw commented Sep 10, 2023

For a large code an example original svg is 1479k, svg-path is 286k, and svg-compressed is 59k.
For a small code it's 22k, 3.7k vs 0.8k.

@johnkw johnkw closed this Sep 15, 2023
@johnkw johnkw reopened this Sep 15, 2023
j and others added 4 commits September 16, 2023 15:09
…rder to avoid the O(n^2)-ish perf hit for splicing a python list repeatedly. Only store spliceable turns, and assert that we dealt with all of them correctly.
@bartTC bartTC self-assigned this Aug 13, 2024
@bartTC bartTC mentioned this pull request Aug 13, 2024
@maribedran maribedran closed this Sep 27, 2024
@johnkw
Copy link
Author

johnkw commented Sep 27, 2024

Was this actually merged? It says merged here but I don't see it in the commit.

@maribedran
Copy link
Contributor

I'm so sorry, @johnkw ! I saw this PR listed on #370 and didn't check if all the changes were incorporated there. The PNG import was fixed, but not the SVG classes. I'll reopen the PR.

@maribedran maribedran reopened this Sep 28, 2024
@johnkw johnkw changed the title Only import png if needed. Add "svg-compressed" to create a simple classic QR Code with compressed file size. Add "svg-compressed" to create a simple classic QR Code with compressed file size. Allow execution from a development environment. Sep 28, 2024
@johnkw
Copy link
Author

johnkw commented Sep 28, 2024

Re-merged and complied with ruff and apparent v3.9 compatibility requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants