Merge pull request #99 from lindell/new-issue-96

Fixed issue #96
lindell · Sep 3, 2016 · c31ed76 · c31ed76
2 parents e298b34 + 856f7de
commit c31ed76
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/src/JsBarcode.js b/src/JsBarcode.js
@@ -157,7 +157,7 @@ API.prototype.init = function(){
 // The render API call. Calls the real render function.
 API.prototype.render = function(){
 	if(Array.isArray(this._renderProperties)){
-		for(let i in this._renderProperties){
+		for(var i = 0; i < this._renderProperties.length; i++){
 			render(this._renderProperties[i], this._encodings, this._options);
 		}
 	}

diff --git a/test/node/JsBarcode.test.js b/test/node/JsBarcode.test.js
@@ -112,6 +112,17 @@ describe('Text printing', function() {
   });
 });
 
+describe('Extended Arrays', function() {
+  it('should work with extended arrays', function () {
+    Array.prototype.test = function(){};
+    Array.prototype._test = "test";
+
+    var canvas = new Canvas();
+    JsBarcode(canvas, "Hello");
+    JsBarcode(canvas, "HI", {format: "CODE39"});
+  });
+});
+
 describe('Generic barcode', function() {
   it('should not fail generic barcode', function () {
     var enc = new GENERIC("1234");

diff --git a/test/node/help/help.js b/test/node/help/help.js
@@ -9,7 +9,7 @@ module.exports.fixBin = function(a){
 function mergeToText(encodeData){
   if(Array.isArray(encodeData)){
     var ret = "";
-    for(var i in encodeData){
+    for(var i = 0; i < encodeData.length; i++){
       ret += encodeData[i].text || "";
     }
     return ret;
@@ -22,7 +22,7 @@ function mergeToText(encodeData){
 function mergeToBin(encodeData){
   if(Array.isArray(encodeData)){
     var ret = "";
-    for(var i in encodeData){
+    for(var i = 0; i < encodeData.length; i++){
       ret += toBin(encodeData[i].data);
     }
     return ret;