Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove refs to deprecated io/ioutil #350

Merged
merged 1 commit into from
Jul 31, 2023
Merged

chore: remove refs to deprecated io/ioutil #350

merged 1 commit into from
Jul 31, 2023

Conversation

testwill
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kkdai kkdai self-requested a review July 31, 2023 02:14
@kkdai
Copy link
Member

kkdai commented Jul 31, 2023

Checking the PR.

Add reason:
io/ioutil is deprecated since go 1.16, refer to https://pkg.go.dev/io/ioutil

@kkdai
Copy link
Member

kkdai commented Jul 31, 2023

Hi @testwill
Would you please help to sigh the CLA?

@kkdai
Copy link
Member

kkdai commented Jul 31, 2023

Since this change (#321), we should move forward our package to 1.19.
Let me check with other reviewers

kkdai
kkdai approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@kkdai kkdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkdai kkdai merged commit 527ce48 into line:master Jul 31, 2023
0 of 7 checks passed
@testwill testwill deleted the ioutil branch July 31, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkdai kkdai kkdai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@testwill @CLAassistant @kkdai