Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go 1.21 and drop 1.19 #383

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

Yang-33
Copy link
Contributor

@Yang-33 Yang-33 commented Oct 31, 2023

I found 1.19 was EOL and 1.21 was released : https://endoflife.date/go

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f21563) 78.89% compared to head (4ac0de4) 78.89%.
Report is 1 commits behind head on master.

❗ Current head 4ac0de4 differs from pull request most recent head 9c67249. Consider uploading reports for the commit 9c67249 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #383   +/-   ##
=======================================
  Coverage   78.89%   78.89%           
=======================================
  Files          41       41           
  Lines        3714     3714           
=======================================
  Hits         2930     2930           
  Misses        592      592           
  Partials      192      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tokuhirom
Copy link
Member

You may need to update https://github.com/line/line-bot-sdk-go/blob/master/go.mod#L3 too.

Copy link
Member

@tokuhirom tokuhirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you update go.mod in same PR~

@Yang-33
Copy link
Contributor Author

Yang-33 commented Nov 1, 2023

Thank you! 9c67249 updated it~

@Yang-33 Yang-33 merged commit ba62e0f into line:master Nov 1, 2023
5 checks passed
@Yang-33 Yang-33 deleted the support-new-go-version branch November 1, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants