feat: allow string responses #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for storybook-addon-mock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I would love this feature. It is quite a severe limitation to only be able to return objects and arrays. Hope the PR gets merged |
|
Nice, I hope this gets merged. There's still a small issue though: when using fetchXhrRequest it still uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the support for returning a string value in a response instead of only allowing JSON. Adding the change to the Storybook docs in
packages/mock-addon-docsrequires some bigger changes in the test files, so I haven't done that yet because I wanted to wait for your feedback on whether you want to accept the PR and if so, how it should be added to the docs.Closes #200 .