Add methods to map color components #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are convenience methods, but should provide a nice concise way to express common operations on colors, subsuming a lot of single-use methods. Arguably 'map_lightness' should become a method on `ColorSpace`, very similar to `scale_chroma`, as similar math optimizations apply.
waywardmonkeys
approved these changes
Nov 6, 2024
xorgy
approved these changes
Nov 6, 2024
tomcur
approved these changes
Nov 6, 2024
| /// Otherwise, do the mapping in Oklab. The lightness range is normalized so | ||
| /// that 1.0 is white. | ||
| #[must_use] | ||
| pub fn map_lightness(self, f: impl Fn(f32) -> f32) -> Self { |
There was a problem hiding this comment.
Another candidate would be map_hue due to its natural representation in all polar spaces.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are convenience methods, but should provide a nice concise way to express common operations on colors, subsuming a lot of single-use methods.
Arguably 'map_lightness' should become a method on
ColorSpace, very similar toscale_chroma, as similar math optimizations apply.