Skip to content

Less overzealous inlining #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shnatsel wants to merge 2 commits into
base: main
Choose a base branch
from
+0 −10
Open

Less overzealous inlining #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e45eaff
drop #[inline] on vectorize from the generator
Shnatsel Jan 22, 2026
4e4c367
re-run the generator
Shnatsel Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions fearless_simd/src/generated/avx2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,8 @@ impl Simd for Avx2 {
fn level(self) -> Level {
Level::Avx2(self)
}
#[inline]
fn vectorize<F: FnOnce() -> R, R>(self, f: F) -> R {
#[target_feature(enable = "avx2,fma")]
#[inline]
unsafe fn vectorize_avx2<F: FnOnce() -> R, R>(f: F) -> R {
f()
}
Expand Down
1 change: 0 additions & 1 deletion fearless_simd/src/generated/fallback.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ impl Simd for Fallback {
#[cfg(not(feature = "force_support_fallback"))]
Level::baseline()
}
#[inline]
fn vectorize<F: FnOnce() -> R, R>(self, f: F) -> R {
f()
}
Expand Down
2 changes: 0 additions & 2 deletions fearless_simd/src/generated/neon.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,8 @@ impl Simd for Neon {
fn level(self) -> Level {
Level::Neon(self)
}
#[inline]
fn vectorize<F: FnOnce() -> R, R>(self, f: F) -> R {
#[target_feature(enable = "neon")]
#[inline]
unsafe fn vectorize_neon<F: FnOnce() -> R, R>(f: F) -> R {
f()
}
Expand Down
2 changes: 0 additions & 2 deletions fearless_simd/src/generated/sse4_2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,8 @@ impl Simd for Sse4_2 {
Level::baseline()
}
}
#[inline]
fn vectorize<F: FnOnce() -> R, R>(self, f: F) -> R {
#[target_feature(enable = "sse4.2")]
#[inline]
unsafe fn vectorize_sse4_2<F: FnOnce() -> R, R>(f: F) -> R {
f()
}
Expand Down
1 change: 0 additions & 1 deletion fearless_simd/src/generated/wasm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ impl Simd for WasmSimd128 {
fn level(self) -> Level {
Level::WasmSimd128(self)
}
#[inline]
fn vectorize<F: FnOnce() -> R, R>(self, f: F) -> R {
f()
}
Expand Down
2 changes: 0 additions & 2 deletions fearless_simd_gen/src/level.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ pub(crate) trait Level {
let vectorize = format_ident!("vectorize_{}", self.name().to_ascii_lowercase());
quote! {
#[target_feature(enable = #target_features)]
#[inline]
unsafe fn #vectorize<F: FnOnce() -> R, R>(f: F) -> R {
f()
}
Expand Down Expand Up @@ -149,7 +148,6 @@ pub(crate) trait Level {
#level_body
}

#[inline]
fn vectorize<F: FnOnce() -> R, R>(self, f: F) -> R {
#vectorize_body
}
Expand Down