Hang trailing whitespace preceding explicit newline #276
Conversation
| // An RTL layout that has a line that ends with a space followed by a | ||
| // forced line break will always have a separate run that looks like: | ||
| // [" ", "\n"]. This means that the first cluster of a run with trailing |
There was a problem hiding this comment.
Could you explain why this is? Perhaps with an example? I believe you, but in terms of providing a meaningful review, I'm not currently fully following the logic here.
There was a problem hiding this comment.
So, I have to be honest here, and tell you that I don't exactly know why RTL works like this. I assume that the space can be that the explicit newline forces mixed direction runs in the BiDi algorithm, but from my first skimming of https://www.unicode.org/reports/tr9/, line separators should be treated the same as any white space.
In any case, the current shaper gives you three runs like this: [RTL("ااااا"), LTR(" \n"), RTL("بببب")], with the explicit newline. Without it you get just one run like this: [RTL("بببب ااااا"].
I'll make this PR a draft until I understand it better and can explain it.
wfdewith
force-pushed
the
trailing-whitespace-newline
branch
from
724e443 to
29e479e
Compare
Fixes #263