Support path attribute on <textPath> element#1020
Support path attribute on <textPath> element#1020yisibl wants to merge 4 commits intolinebender:mainfrom
path attribute on <textPath> element#1020Conversation
yisibl
changed the title
path attribute on <textPath> elementpath attribute on <textPath> element
|
In Chrome I'm not seeing any text on most of those, is that intended? |
LaurenzV
left a comment
LaurenzV
left a comment
There was a problem hiding this comment.
LGTM, just two comments.
| xmlns:xlink="http://www.w3.org/1999/xlink"> | ||
| <title>With partially invalid `path` and `xlink:href` fallback (SVG 2)</title> | ||
| <desc> | ||
| If the `path` attribute contains any parse error, the `xlink:href` path must be used. |
There was a problem hiding this comment.
But right now, the text is not using the xlink:href one, right?
There was a problem hiding this comment.
(Seems to be what Firefox and CHrome do, but then the comment itself confuses me.
|
Thank you for your review. I'm awaiting updates from SVGWG regarding their findings and tests. I'll be back later. |
|
Thank you for your review. I'm awaiting updates from SVGWG regarding their findings and tests.
I'll be back later. |
|
Chrome currently does not support using Basic shapes within
|
2 participants
Currently, there is a conflict within the SVG2 specification regarding:
Both @AmeliaBR and @karlcow believe this should be removed from the specification w3c/svgwg#393 (comment), which is what the current PR does. This also maintains interoperability with browser implementations.
I added a test case for this purpose: textPath/with-error-path.svg
See also:
Fixes: #417