Open
Conversation
armansito
reviewed
Oct 17, 2023
| @@ -0,0 +1,25 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 OR MIT OR Unlicense | |||
Collaborator
There was a problem hiding this comment.
Why is this shader necessary? Can't we use wgpu::CommandEncoder::copy_buffer_to_texture or Command::UploadImage to perform the upload?
Collaborator
Author
There was a problem hiding this comment.
That can't be used with just a texture view.
Zoxc
force-pushed
the
fine-shader
branch
2 times, most recently
from
7f2f740 to
0747e52
Compare
xStrom
reviewed
Feb 24, 2024
| @@ -0,0 +1,25 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 OR MIT OR Unlicense | |||
Member
There was a problem hiding this comment.
Since #456 we have standard copyright headers. Please update this shader file to be consistent with the others.
Suggested change
| // SPDX-License-Identifier: Apache-2.0 OR MIT OR Unlicense | |
| // Copyright 2023 the Vello Authors | |
| // SPDX-License-Identifier: Apache-2.0 OR MIT OR Unlicense |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hooks up the
fineCPU shader to the rest of the infrastructure.TransientBindMapis moved outside ofrun_recordingto allow passing CPU buffers from coarse to fine.TransientImage::CpuOwnedCPU buffer forWriteOnceimages. This is used to hold the result offine.Command::Writebackwhich writesTransientImage::CpuOwnedback into a GPU texture view using the newwriteback.wgslshader.This is based on #383.