Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: backslash in tagged template #125

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: backslash in tagged template #125

wants to merge 2 commits into from

Conversation

Jack-Works
Copy link

This PR fixes \n being extracted to \\n.

timofei-iatsenko
timofei-iatsenko requested changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@timofei-iatsenko timofei-iatsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There two changes in the code, but only one test added. It seems there are cases which is not covered.

The second case might be

<Trans>{`Multiline\nstring`}</Trans>

(please test it with and without fix, because i just took it from mi mind)

src/ast_utils.rs Outdated Show resolved Hide resolved
@Jack-Works
Copy link
Author

Hi @timofei-iatsenko thanks for the review, I have updated the PR and added one case, but I cannot fix that case. I tried 2 to 3 different ways but to fix that case it looks like I need to rewrite a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timofei-iatsenko timofei-iatsenko timofei-iatsenko requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jack-Works @timofei-iatsenko