CRUD by linhlt311 · Pull Request #1 · linhlt311/ERP_BackEndTraining

linhlt311 · 2018-02-08T11:06:32Z

No description provided.

hapo-truongpm · 2018-02-08T11:11:44Z

app/Http/Controllers/ManageUserController.php

    {
-        $employees = Employee::paginate(5);
+        $employees = Employee::orderBy('updated_at','desc')->paginate(5);
+//        dd($employees);


bỏ dd đi em, nếu như chỉ có 1 biến thì không cần cho vào mảng data cũng đc

@linhlt311 Done mà sao vẫn còn dd thế này em ?

hapo-truongpm · 2018-02-08T11:15:05Z

app/Http/Requests/StoreEmployeeRequest.php

+        return [
+            "email" => 'unique:employees|max:255',
+            "name" => "max:255",
+            "phone" => "max:255",


name như này là nhập được cả số cả các ký tự đặc biệt à
phone thì nhập được cả chữ

hapo-truongpm · 2018-02-08T11:16:50Z

app/Http/Requests/StoreEmployeeRequest.php

+    {
+        return [
+            'img.required'  => 'Profile image is required',
+        ];


trên không có rule cho img mà dưới này lại có message là sao nhỉ

hapo-truongpm · 2018-02-08T11:19:30Z

resources/views/admin/users/create.blade.php

+                        @foreach ($errors->all() as $error)
+                            <li>{{ $error }}</li>
+                        @endforeach
+                    </ul>


anh nghĩ là nên cho mỗi error vào từng input tương ứng thay vì hiện ra tất như này

@TruongPhan16 à tức là hiện thi lỗi trên mỗi cái input hở?

hapo-truongpm · 2018-02-08T11:20:02Z

resources/views/admin/users/create.blade.php

+            @endif
            <!-- form start -->
-            <form role="form" action="{{route('user.store')}}" method="post">
+            <form role="form" action="{{route('user.store')}}" method="post" enctype="multipart/form-data">


thiếu space giữa {{}}

@TruongPhan16 là viết kiểu {{ route('user.store') }} hả anh?

@linhlt311 ừm

thiennguyen84 · 2018-02-11T09:11:34Z

app/Http/Requests/StoreEmployeeRequest.php

@@ -27,7 +27,7 @@ public function rules()
            "email" => 'unique:employees|max:255',


@linhlt311 cái này thì nội dung thông báo lỗi ở đâu vậy

@thiennguyen84 là sao nhỉ? cái này em k làm error message, dùng luôn default của nó

nguyenvanpho · 2018-02-11T09:18:28Z

resources/views/admin/users/edit.blade.php

            <!-- form start -->
-            <form role="form" action="{{url('user')}}/{{$employee->id}}" method="post">
-                {{csrf_field()}}
+            <form role="form" action="{{ url('user') }}/{{ $employee->id }}" method="post">


@linhlt311 sao chỗ này vẫn dùng url thế em?

nguyenvanpho · 2018-02-11T09:19:32Z

resources/views/admin/users/index.blade.php

+                                <td>{{ $employee->JLPT }}</td>
                                <td>
-                                    <a href="{{url('user')}}/{{$employee->id}}">
+                                    <a href="{{ url('user') }}/{{ $employee->id }}">


dùng route:('name') đi em

nguyenvanpho · 2018-02-11T09:19:51Z

resources/views/admin/users/index.blade.php

                                </td>
                                <td>
-                                    <a href="{{url('user')}}/{{$employee->id}}/edit">
+                                    <a href="{{ url('user')}}/{{ $employee->id }}/edit">


hapo-anhht · 2018-02-11T10:53:16Z

resources/views/admin/users/show.blade.php

                </div>
                <div class="box-body">
-                    <img class="profile-user-img img-responsive img-circle" src="{{ url('storage') }}/{{ $employee->image }}" alt="User profile picture">
+                    <img class="profile-user-img img-responsive img-circle" src="{{ asset('storage') }}/{{ $employee->image }}" alt="User profile picture">


asset('storage/'.$employee->image) cho ngan nhe

hapo-anhht · 2018-02-11T10:55:10Z

resources/views/admin/users/edit.blade.php

            <!-- /.box-header -->
            <!-- form start -->
-            <form role="form" action="{{ route('user.edit', $employee->id) }}" method="post">
+            <form role="form" action="{{ route('user.update', $employee->id) }}" method="post">


cai nay co nen them {{ method_field("UPDATE") }} KHONG NHI

Khong can vi co input _method o duoi r

ghost · 2018-02-12T06:53:49Z

app/Employee.php

 class Employee extends Model
 {
-    //
+    protected $fillable = ['name', 'gender', 'email', 'phone_number', 'address', 'JLPT', 'image'];


@linhlt311 không khai báo cái này có sao ko ?

@damnnkst nếu bỏ đi thì em không add mới đc anh ạ

ghost · 2018-02-12T06:54:13Z

app/Http/Controllers/ManageUserController.php

    public function index()
    {
-        $employees = Employee::paginate(5);
+        $employees = Employee::orderBy('updated_at','desc')->paginate(5);


@linhlt311 hạn chế hardcode move 5 vào trong config nhé

ghost · 2018-02-12T06:54:29Z

app/Http/Controllers/ManageUserController.php

+    public function store(StoreEmployeeRequest $request)
    {
        $data = $request->all();
        $data = array_slice($data, 1);


@linhlt311 sao phải làm việc này ?

ghost · 2018-02-12T06:54:47Z

app/Http/Controllers/ManageUserController.php

        $data = $request->all();
        $data = array_slice($data, 1);
-        Employee::insert($data);
+        if (array_key_exists('img', $data)) {


@linhlt311 có cách nào check khác tốt hơn ko ?

Fixed. Đổi sang hasFile

ghost · 2018-02-12T06:55:47Z

app/Http/Controllers/ManageUserController.php

    public function show($id)
    {
-        $employee = Employee::find($id);
+        $employee = Employee::findOrFail($id);


@linhlt311 phân biệt giúp a sự khác nhau giữa find và findOrFail

@damnnkst find không trùng thì nó trả lại null còn findOrFail không trùng thì nó throw error anh ơi

ghost · 2018-02-12T06:56:15Z

app/Http/Controllers/ManageUserController.php

    }
+
+    public function updateImage(Request $request, $id) {
+        $imgLink = $request->file('img')->store('public/images');


@linhlt311 ko validate phần này à ?

ghost · 2018-02-12T06:56:35Z

app/Http/Controllers/ManageUserController.php

+
+    public function updateImage(Request $request, $id) {
+        $imgLink = $request->file('img')->store('public/images');
+        $imgLink = substr($imgLink, 7);


@linhlt311 sao lại phải làm thế này ?

@damnnkst em cut cái chữ public/ ở đâu đi để về sau gọi ảnh cho nó dễ ạ

ghost · 2018-02-12T06:56:50Z

app/Http/Controllers/ManageUserController.php

+        $imgLink = $request->file('img')->store('public/images');
+        $imgLink = substr($imgLink, 7);
+        $data["image"] = $imgLink;
+        Employee::where('id',$id)->update($data);


@linhlt311 thay hàm where bằng hàm khác đc ko ?

Đã đổi thành find

ghost · 2018-02-12T06:57:18Z

app/Http/Controllers/UserController.php

@@ -9,7 +9,6 @@ class UserController extends Controller
 {
    public function show() {
        $employee = Employee::get();


@linhlt311 hàm này có dùng ko e ?

ghost · 2018-02-12T06:57:48Z

app/Http/Requests/StoreEmployeeRequest.php

+            "name" => "max:255|regex:/^[\p{L}\s'.-]+$/u",
+            "phone_number" => "min:6|max:20|regex:/^[0-9]*$/",
+            "address" => "max:255",
+        ];


@linhlt311 thêm cho a phần custom nội dung các message trả về nhé

Added custom message

ghost · 2018-02-12T06:58:16Z

database/migrations/2018_02_05_173504_create_employees_table.php

+            $table->string('phone_number')->nullable();
+            $table->string('address')->nullable();
            $table->string('JLPT');
+            $table->text('image');


@linhlt311 trường này có cần dùng đến text ko e ?

@damnnkst em nghĩ nên để text vì có khả năng là cái link ảnh nó dài ạ

ghost · 2018-02-12T06:58:56Z

resources/views/admin/users/create.blade.php

+        function readURL(input) {
+
+            if (input.files && input.files[0]) {
+                var reader = new FileReader();


@linhlt311 biết es6 chưa e ?

Đã đổi sang let

ghost · 2018-02-12T07:00:04Z

resources/views/admin/users/index.blade.php

                    dangerMode: true,
                })
-                    .then((willDelete) = > {
+                    .then((willDelete) => {


@linhlt311 có nhất thiết phải viết then đoạn này ko ?

@damnnkst cái này em làm theo document của nó thôi ạ. Nhưng mà then thì nó mới chạy cái ajax chứ nhỉ

ghost · 2018-02-12T07:00:20Z

resources/views/admin/users/index.blade.php

                        $.ajax({
                            type: 'delete',
                            url: 'user/' + id,
                            success: function (response) {


@linhlt311 ko có case error à e ?

linhlt311 added 3 commits February 8, 2018 00:47

Added validator and image upload

ffb17dd

Implement Modal

965b9f4

CRUD Finished

0fd8f0c

hapo-truongpm reviewed Feb 8, 2018

View reviewed changes

linhlt311 added 2 commits February 11, 2018 15:56

Update validation

2f81b81

Upade validation

6aeb99b

thiennguyen84 reviewed Feb 11, 2018

View reviewed changes

nguyenvanpho reviewed Feb 11, 2018

View reviewed changes

linhlt311 added 2 commits February 11, 2018 16:53

Change url to route

1ea9d1d

Delete dd(), fix validation

dd44d63

hapo-anhht reviewed Feb 11, 2018

View reviewed changes

nguyenvanpho approved these changes Feb 12, 2018

View reviewed changes

hapo-truongpm approved these changes Feb 12, 2018

View reviewed changes

ghost reviewed Feb 12, 2018

View reviewed changes

linhlt311 added 4 commits February 15, 2018 17:07

Deleted unnecessary code, Added validation message

b86c091

Add softdelete, Add attributes to model

ebb76d4

Able to use unique with soft delete

2eb26ad

Fix views/edit

b2b2cd2

		@@ -27,7 +27,7 @@ public function rules()
		"email" => 'unique:employees\|max:255',

Conversation

linhlt311 commented Feb 8, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hapo-truongpm Feb 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nguyenvanpho Feb 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

hapo-truongpm Feb 8, 2018 •

edited

Loading

nguyenvanpho Feb 11, 2018 •

edited

Loading