Add BlobId v7 with migration destination bit#3206
Draft
j-tyler wants to merge 1 commit intolinkedin:masterfrom
Draft
Add BlobId v7 with migration destination bit#3206j-tyler wants to merge 1 commit intolinkedin:masterfrom
j-tyler wants to merge 1 commit intolinkedin:masterfrom
Conversation
BlobId v6 has no field to denote backend identity at write time, which makes migration to a new backend infrastucture ambiguous. Add BlobId v7 and reserve the top flag bit for migration destination (AMBRY/NON_AMBRY) while keeping v6-style compact UUID encoding. Keep pre-v7 behavior unchanged by defaulting migration metadata to UNKNOWN and reject UNKNOWN for v7 constructors/craft APIs. Also allow router.blobid.current.version=7 and add coverage for router config bounds, v7 serde, craft behavior, and migration destination validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BlobId v6 has no field to denote backend identity at write time, which makes migration to a new backend infrastucture ambiguous.
Add BlobId v7 and reserve the top flag bit for migration destination (AMBRY/NON_AMBRY) while keeping v6-style compact UUID encoding. Keep pre-v7 behavior unchanged by defaulting migration metadata to UNKNOWN and reject UNKNOWN for v7 constructors/craft APIs.
Also allow router.blobid.current.version=7 and add coverage for router config bounds, v7 serde, craft behavior, and migration destination validation.
Testing Done
Added new tests to cover all changes.