HEAD requests content-length is not based on the body as per the http spec. #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpstewart
force-pushed
the
header-content-length-fix-jostewar
branch
from
d0d4293 to
4bb833d
Compare
nizarm
approved these changes
May 10, 2023
Contributor
nizarm
left a comment
nizarm
left a comment
There was a problem hiding this comment.
Did we do a wc-test as per the pegasus release protocol? If yes, please feel free to merge this and release a version for espresso.
jpstewart
force-pushed
the
header-content-length-fix-jostewar
branch
from
4bb833d to
bec1a8b
Compare
… spec. Fixing it to not override the content-length if the request is HEADER type.
jpstewart
force-pushed
the
header-content-length-fix-jostewar
branch
from
bec1a8b to
4671c3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing it to not override the content-length if the request is HEADER type.
This is resubmission of a previous PR #896