Skip to content

Separate tls::ServerName and identity::Id types #1350

Separate tls::ServerName and identity::Id types

Separate tls::ServerName and identity::Id types #1350

Triggered via pull request November 7, 2023 19:42
@olix0rolix0r
synchronize #2506
ver/ids
Status Failure
Total duration 2m 41s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

3 errors
clippy: linkerd/meshtls/boring/src/tests.rs#L9
error[E0061]: this function takes 5 arguments but 4 arguments were supplied --> linkerd/meshtls/boring/src/tests.rs:7:22 | 7 | let (store, _) = crate::creds::watch( | ^^^^^^^^^^^^^^^^^^^ 8 | ent.name.parse().unwrap(), 9 | roots_pem, | --------- an argument of type `linkerd_dns_name::Name` is missing | note: function defined here --> linkerd/meshtls/boring/src/creds.rs:16:8 | 16 | pub fn watch( | ^^^^^ 17 | local_id: id::Id, | ---------------- 18 | server_name: dns::Name, | ---------------------- 19 | roots_pem: &str, | --------------- 20 | key_pkcs8: &[u8], | ---------------- 21 | csr: &[u8], | ---------- help: provide the argument | 7 | let (store, _) = crate::creds::watch(ent.name.parse().unwrap(), /* linkerd_dns_name::Name */, roots_pem, b"fake CSR data", ent.key) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
clippy: linkerd/meshtls/boring/src/tests.rs#L7
error[E0061]: this function takes 5 arguments but 4 arguments were supplied --> linkerd/meshtls/boring/src/tests.rs:7:22 | 7 | let (store, _) = crate::creds::watch( | ^^^^^^^^^^^^^^^^^^^ 8 | ent.name.parse().unwrap(), 9 | roots_pem, | --------- an argument of type `linkerd_dns_name::Name` is missing | note: function defined here --> linkerd/meshtls/boring/src/creds.rs:16:8 | 16 | pub fn watch( | ^^^^^ 17 | local_id: id::Id, | ---------------- 18 | server_name: dns::Name, | ---------------------- 19 | roots_pem: &str, | --------------- 20 | key_pkcs8: &[u8], | ---------------- 21 | csr: &[u8], | ---------- help: provide the argument | 7 | let (store, _) = crate::creds::watch(ent.name.parse().unwrap(), /* linkerd_dns_name::Name */, roots_pem, b"fake CSR data", ent.key) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
clippy
Process completed with exit code 1.