Skip to content

Commit

Permalink
fix(http): fix outbound HTTP metrics naming (#2903)
Browse files Browse the repository at this point in the history
31d7464 introduced a naming regression, so that metrics that 'outbound_http_'
became 'outbound_http_http_'. This change fixes this regression.
  • Loading branch information
olix0r authored Apr 18, 2024
1 parent 014065d commit 802d93e
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions linkerd/app/outbound/src/metrics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,13 @@ where

impl PromMetrics {
pub fn register(registry: &mut prom::Registry) -> Self {
Self {
http: crate::http::HttpMetrics::register(registry.sub_registry_with_prefix("http")),
opaq: crate::opaq::OpaqMetrics::register(registry.sub_registry_with_prefix("tcp")),
}
// NOTE: HTTP metrics are scoped internally, since this configures both
// HTTP and gRPC scopes.
let http = crate::http::HttpMetrics::register(registry);

let opaq = crate::opaq::OpaqMetrics::register(registry.sub_registry_with_prefix("tcp"));

Self { http, opaq }
}
}

Expand Down

0 comments on commit 802d93e

Please sign in to comment.