Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Compute coverage over all tests #2525

Closed
wants to merge 5 commits into from
Closed

ci: Compute coverage over all tests #2525

wants to merge 5 commits into from

Conversation

olix0r
Copy link
Member

@olix0r olix0r commented Nov 16, 2023

Our coverage workflow only measures the coverage of integration tests, ignoring all of our unit tests and component tests. This is caused by our inclusion of tests that don't run in CI in the default integration test configuration.

In order to run coverage over all tests, we disable two flakey tests from the default integration test configuration. The tests that are flakey only in coverage are simply enabled. Instead, we'll tolerate test failures in our coverage reports. We'll trust that our tests are actually executed successfully outside of the coverage run.

Our coverage workflow only measures the coverage of integration tests,
ignoring all of our unit tests and component tests. This is caused by
our inclusion of tests that don't run in CI in the default integration
test configuration.

In order to run coverage over all tests, we disable two flakey tests
from the default integration test configuration. The tests that are
flakey only in coverage are simply enabled. Instead, we'll tolerate test
failures in our coverage reports. We'll trust that our tests are
actually executed successfully outside of the coverage run.
@olix0r olix0r requested a review from a team as a code owner November 16, 2023 23:52
@olix0r olix0r marked this pull request as draft November 17, 2023 00:05
@olix0r olix0r marked this pull request as ready for review November 17, 2023 00:23
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (2ad49d6) 58.79% compared to head (9690281) 67.86%.
Report is 2 commits behind head on main.

Files Patch % Lines
linkerd/app/admin/src/pprof.rs 0.00% 32 Missing ⚠️
linkerd/app/admin/src/server.rs 0.00% 14 Missing ⚠️
linkerd/app/admin/src/stack.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2525      +/-   ##
==========================================
+ Coverage   58.79%   67.86%   +9.07%     
==========================================
  Files         326      343      +17     
  Lines       15374    16109     +735     
==========================================
+ Hits         9039    10933    +1894     
+ Misses       6335     5176    -1159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olix0r olix0r closed this Nov 17, 2023
@olix0r olix0r reopened this Nov 17, 2023
@olix0r olix0r closed this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant