proxy-http: Box request bodies #2848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proxy HTTP server emits requests with an UpgradeBody type (as required by the server module that sets up HTTP CONNECT handling). We also wrap HTTP/2 requests in this body even though we do not currently support CONNECT over HTTP/2. The inbound and outbound server stacks then Box the request body so that the UpgradeBody type is hidden. This commit moves the Box-ing of the request body into the HTTP server to reduce boilerplate. This change sets up for additional HTTP server changes. There are no functional changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxy HTTP server emits requests with an UpgradeBody type (as required by the server module that sets up HTTP CONNECT handling). We also wrap HTTP/2 requests in this body even though we do not currently support CONNECT over HTTP/2. The inbound and outbound server stacks then Box the request body so that the UpgradeBody type is hidden.
This commit moves the Box-ing of the request body into the HTTP server to reduce boilerplate.
This change sets up for additional HTTP server changes. There are no functional changes.