feat: drop FranzDiebold/github-env-vars-action gh-action #9641
#129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhitza
reviewed
Mar 18, 2025
mhitza
requested changes
Mar 18, 2025
Collaborator
mhitza
left a comment
mhitza
left a comment
There was a problem hiding this comment.
Looks good. I'd like the variable usage to be extended.
I've removed your breaking change flag for this change. I'd reserve that for when all changes stabilize and a v1 version becomes necessary.
This drops the `FranzDiebold/github-env-vars-action` in favor of native
GH-Actions replacement patterns available.
Notable replacements:
- `${{ env.CI_REPOSITORY_OWNER_SLUG }}`: `$(echo '${{ github.repository }}' | tr '[:upper:]' '[:lower:]')`
- `${{ env.CI_REPOSITORY_NAME }}`: `${{ github.event.repository.name }}`
Related: [#9639](http://team.linkorb.com/cards/9639) and linkorb/php-docker-base#16.
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the
FranzDiebold/github-env-vars-actionin favor of native GH-Actions replacement patterns available.Notable replacements:
${{ env.CI_REPOSITORY_OWNER_SLUG }}:$(echo '${{ github.repository }}' | tr '[:upper:]' '[:lower:]')${{ env.CI_REPOSITORY_NAME }}:${{ github.event.repository.name }}Related: #9639 and linkorb/php-docker-base#16.
Checklist