Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation errors in get_link_by_id function #8

Closed
wants to merge 5 commits into from
Closed

Fix compilation errors in get_link_by_id function #8

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
80799e3
feat: Updated src/main.rs
linksplatform-sweepai[bot] Sep 20, 2023
26d3bfb
feat: Updated src/main.rs
linksplatform-sweepai[bot] Sep 20, 2023
2c67324
feat: Updated src/main.rs
linksplatform-sweepai[bot] Sep 20, 2023
ddade97
feat: Updated src/main.rs
linksplatform-sweepai[bot] Sep 20, 2023
4d7a62f
feat: Updated src/main.rs
linksplatform-sweepai[bot] Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use doublets::{data::LinkType, mem, unit, Doublets, Error};
use doublets::{data::LinkType, mem, unit, Doublets, Error, LinkType};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
use doublets::{data::LinkType, mem, unit, Doublets, Error, LinkType};
use doublets::{data::LinkType, mem, unit, Doublets, Error};

Copy link
Contributor Author

@linksplatform-sweepai linksplatform-sweepai bot Sep 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

use doublets::{DoubletsExt, Links};
use tap::Pipe;

Expand Down Expand Up @@ -67,7 +67,7 @@ fn nand(a: bool, b: bool) -> bool {
!(a && b)
}

fn get_link_by_id(store: &mut unit::Store<usize, _>, id: usize) -> Result<Link<usize>, Error<usize>> {
fn get_link_by_id<T>(store: &mut unit::Store<usize, T>, id: usize) -> Result<Link<usize>, Error<usize>> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add a type parameter also update all usages of this function to be correct. Use LinkType instead of Link here.

Copy link
Contributor Author

@linksplatform-sweepai linksplatform-sweepai bot Sep 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

// `any` constant denotes any link
let any = store.constants().any;
let mut link_result = Err(Error::new("Link not found"));
Expand Down