Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: crawler extension #91

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: crawler extension #91

wants to merge 2 commits into from

Conversation

load1n9
Copy link

@load1n9 load1n9 commented Sep 30, 2024

No description provided.

Copy link
Owner

@lino-levan lino-levan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks good, but I'm unsure that there is actually demand for this. I'll wait for reactions on this PR.

@chaosharmonic
Copy link
Contributor

👀 👀 👀

I'm skimming this currently but given that scraping is my primary use for Astral I'm definitely curious.

Tell me more?

@lino-levan
Copy link
Owner

@load1n9 Could you run deno fmt?

@nnmrts
Copy link

nnmrts commented Dec 16, 2024

It would probably be better here to integrate with https://crawlee.dev/ instead of reinventing the wheel.

@chaosharmonic
Copy link
Contributor

chaosharmonic commented Dec 17, 2024

Some of this also could be deeper and cover other issues. User agent has since been covered separately, but there also
looks to be what would be an implementation here of Page.loadScriptTag (potentially similar to #96), and various other stuff.

Notably, without a deeper look at this, sessionManagement seems like it could encounter the same problems laid out in #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants