-
Notifications
You must be signed in to change notification settings - Fork 368
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #9536 from hana-linode/fix-encoding
## Description 📝 Follow up to #9494. The previous PR fixed the Cloud crashing issue, but introduced another issue where we were not unescaping the encoded user data. So, when running the `atob` function on the user data, the output string included `%`s instead of just the original string. reading: https://base64.guru/developers/javascript/examples/unicode-strings https://stackoverflow.com/questions/30631927/converting-to-base64-in-javascript-without-deprecated-escape-call (see the second answer by `T S`) ## How to test 🧪 - Add a console log after line 706 to log the user data `console.log(utoa(this.props.userData))` - Follow the steps in #9494 - Take the result of the console log and run `atob` - The result should be readable and not have unexpected characters such as `%`
- Loading branch information
Showing
4 changed files
with
31 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@linode/manager": Fixed | ||
--- | ||
|
||
Unescape encoding for user data ([#9536](https://github.com/linode/manager/pull/9536)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters