Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8674] - Compare cypress and storybook component tests for Autocomplete component #11155

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Oct 24, 2024

Description 📝

Compares cypress and storybook component tests for Autocomplete component

  • note: I've not finished all the tests I'd want to write/still need to investigate some stuff if this were to be merged, but am putting this up as it should be enough to give an idea of what each feels like! (+ wanted to get this up in time for cafe)
  • left some general thoughts in autocomplete.stories.tsx after writing both >> tldr of those thoughts is that in terms of writing, syntax is fine for both, but for a component with a lot of potential interactions like autocomplete, I prefer cypress a bit more

Huge kudos to

for investigating/setting these up!!

files of note:

  • autocomplete.stories.tsx
  • autocomplete.spec.tsx
storybook cypress
image image

How to test 🧪

I've been testing by running either yarn cy:debug and selecting component testing or running storybook locally and navigating to the autocomplete story (Default and Multi Select). Still need to figure out how to get command line working for both, was running into errors 🥲

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai
Copy link
Contributor Author

coliu-akamai commented Nov 6, 2024

whoops accidentally deleted the branch when I cleaning out old branches

Keeping this open for anyone to look at, also hoping to get to the third testing option soon and add to this PR for more comparison!

@coliu-akamai coliu-akamai reopened this Nov 12, 2024
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 445 passing tests on test run #9 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing445 Passing2 Skipped91m 48s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants