refactor: [M3-8632] - Use pnpm as our package manager #11297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
added
the
Dependencies
|
This PR is stale because it has been open 15 days with no activity. Please attend to this PR or it will be closed in 5 days |
bnussman-akamai
changed the title
pnpm as our package manager
bnussman-akamai
requested review from
jdamore-linode,
hana-akamai,
bill-akamai,
hkhalil-akamai,
jaalah-akamai and
abailly-akamai
and removed request for
a team
bill-akamai
reviewed
Feb 7, 2025
|
|
||
| ## Serving a production build of Cloud Manager | ||
|
|
||
| You can then serve these files however you prefer or use our included local http server. | ||
| You can build a prduction bundle of Cloud Manager and serve it locally. |
There was a problem hiding this comment.
Suggested change
| You can build a prduction bundle of Cloud Manager and serve it locally. | |
| You can build a production bundle of Cloud Manager and serve it locally. |
bill-akamai
reviewed
Feb 7, 2025
| @@ -37,7 +37,7 @@ describe('Link component', () => { | |||
| expect(linkElement.tagName).toBe('A'); | |||
| expect(linkElement).toHaveAttribute('rel', 'noopener noreferrer'); | |||
| expect(linkElement).toHaveAttribute('target', '_blank'); | |||
| expect(linkElement.getAttribute('href')).toBe('https://example.com'); | |||
| expect(linkElement.getAttribute('href')).toBe('https://example.com/'); | |||
There was a problem hiding this comment.
Just curious - any reason why the inclusion of pnpm would require this test to change with a trailing slash? In packages/manager/src/components/MainContentBanner.test.tsx as well?
bill-akamai
approved these changes
Feb 7, 2025
Cloud Manager UI test results🎉 500 passing tests on test run #59 ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Breaking Changes⚠️
upscript (yarn up) has been removed because it conflicts withpnpm up. Usepnpm devinstead to start the local development environmentpnpm devno longer installs dependencies for youpnpm installwhen they deem nessesarypnpm bootstrapis added. It is intended to help developers now thatyarn upno longer exists andpnpm devdoes lesspnpm bootstrapwill install dependencies and build packages (api-v4 and validation)Blocked by 🚧
@mui/systemimports #11081TextFieldto not depend onramda#11306scriptsas a yarn workspace #11420EditableTextUI component pure #11333Todo ☑️
publish-sdkandpublish-validationjobs so our publish step does not fail when resolving workspace protocol dependencies (docs)Risk⚠️
@linode/api-v4and@linode/validationare published in our Github Action. If something goes wrong, worst case is that the packages won't get published to npm on our next release. Cloud Manager itself will not be affected.Follow up work 👷
How to test 🧪
pnpm storybookpnpm devpnpm changesetAs an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅