Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: [M3-9043., M3-9045] - Upgrade Vite to v6 and Vitest to v3 #11548

Merged

Conversation

bnussman-akamai
Copy link
Member

Description 📝

Updates our Vite related dependencies to keep our build tooling up to date ✨

  • Updates Vite from v5 to v6 (latest) 📦
  • Updates Vitest from v2 to v3 (latest) 📦
  • Update @swc/core 📦
  • Updates related Vite and Vitest helper packages 📦

How to test 🧪

  • Verify Cloud Manager works locally
  • Verify Storybook still works
  • Verify the Cypress test suite passes
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bnussman-akamai bnussman-akamai added the Dependencies Pull requests that update a dependency file label Jan 22, 2025
@bnussman-akamai bnussman-akamai self-assigned this Jan 22, 2025
@bnussman-akamai bnussman-akamai marked this pull request as ready for review January 22, 2025 20:44
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner January 22, 2025 20:44
@bnussman-akamai bnussman-akamai requested review from hana-akamai and cpathipa and removed request for a team January 22, 2025 20:44
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 474 passing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing474 Passing2 Skipped115m 1s

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Jan 23, 2025
@hana-akamai hana-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 23, 2025
@bnussman-akamai
Copy link
Member Author

https://github.com/linode/manager/security/dependabot/138 seems to claim that vite v6 isn't patched? Not sure if that's correct or not. It would be great if we could just merge this instead of #11546

@bnussman-akamai
Copy link
Member Author

I think we're good actually (link)

Screenshot 2025-01-23 at 2 57 13 PM

@bnussman-akamai bnussman-akamai merged commit 4d6a55a into linode:develop Jan 23, 2025
23 checks passed
Copy link

cypress bot commented Jan 23, 2025

Cloud Manager E2E    Run #7118

Run Properties:  status check cancelled Cancelled #7118  •  git commit 4d6a55aaaf: deps: [M3-9043., M3-9045] - Upgrade Vite to v6 and Vitest to v3 (#11548)
Project Cloud Manager E2E
Branch Review develop
Run status status check cancelled Cancelled #7118
Run duration 23m 04s
Commit git commit 4d6a55aaaf: deps: [M3-9043., M3-9045] - Upgrade Vite to v6 and Vitest to v3 (#11548)
Committer Banks Nussman
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 0
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants