-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: [M3-9043., M3-9045] - Upgrade Vite to v6 and Vitest to v3 #11548
Merged
bnussman-akamai
merged 2 commits into
linode:develop
from
bnussman-akamai:M3-9043-update-to-vite-v6
Jan 23, 2025
Merged
deps: [M3-9043., M3-9045] - Upgrade Vite to v6 and Vitest to v3 #11548
bnussman-akamai
merged 2 commits into
linode:develop
from
bnussman-akamai:M3-9043-update-to-vite-v6
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloud Manager UI test results🎉 474 passing tests on test run #2 ↗︎
|
jaalah-akamai
approved these changes
Jan 23, 2025
hana-akamai
approved these changes
Jan 23, 2025
https://github.com/linode/manager/security/dependabot/138 seems to claim that vite v6 isn't patched? Not sure if that's correct or not. It would be great if we could just merge this instead of #11546 |
I think we're good actually (link) |
Cloud Manager E2E
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
|
Run duration | 23m 04s |
Commit |
|
Committer | Banks Nussman |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
0
|
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved
Multiple approvals and ready to merge!
Dependencies
Pull requests that update a dependency file
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Updates our Vite related dependencies to keep our build tooling up to date ✨
@swc/core
📦How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅