-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [M3-9198] - Accessibility Issues with LKE Kubeconfig Buttons #11648
base: develop
Are you sure you want to change the base?
change: [M3-9198] - Accessibility Issues with LKE Kubeconfig Buttons #11648
Conversation
… better accessibility and add `aria-label`s in the KubeConfigDisplay
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix - confirmed markup is properly adjusted to improve accessibility on the CTAs ✅
packages/manager/src/features/Kubernetes/KubernetesClusterDetail/KubeConfigDisplay.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ability to tab to each Kubeconfig button ✅
aria-label
present for each Kubeconfig button ✅
Description 📝
This PR replaces
<Box>
elements with<StyledLinkButton>
for better accessibility and addsaria-label
s in the KubeConfigDisplay.Changes 🔄
<Box>
elements with<StyledLinkButton>
components to improve accessibility.Preview 📷
M3-9198.Before.mp4
M3-9198.After.mov
How to test 🧪
aria-label
in Dev Tools.Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅