Various Minor Recipe Cleanups #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ejoerns
commented
Feb 18, 2024
ejoerns
commented
- Removes ineffective and commented-out lines
- adds missing SUMMARY to recipes
- runs oe-stylize to have a more standard structure
Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
…ines * do not prepend FILESEXTRAPATHS from bb file * PV defaults to "1.0" anyway * S was commented out * Add a SUMMARY while at it Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
With a few manual adaptions to fix false-positives. Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
…fication varflags cannot be modified with overrides. The :remove applies to the PACKAGECONFIG variable instead. Since the line did not have any effect anyway, it should be safe to just remove it. Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
…ting
FILES_${PN} still uses old override syntax and has thus no effect.
Since ${bindir} is part of FILES:${PN} anyway, there is no need to set
it and we can just remove the line.
Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
The PACKAGE_ARCH should not be hard-coded to a single MACHINE_ARCH but
contain ${MACHINE_ARCH} instead.
We do not need any compiler deps, thus set INHIBIT_DEFAULT_DEPS.
Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
* Add missing SUMMARY * Make DEPENDS RDEPENDS since python3 is is not required for building * Use [noexec] varflag in favor of empty tasks Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
Gives the recipe a more convenient structure Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
* Add missing SUMMARY * move LICENSE settings to top of file * fix spacing in WEBUI_INSTALL_DIR assignment Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
* drop PR from recipe * add space when using :append Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
1 task
hnez
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Hi,
great pull request, I've learned a lot about best practices and bitbake in general by just reading through the commits.
It would be great to automate some of the recipe file style checks. I've created a draft PR that runs oe-stylize.py as a GitHub action (#114). As you have already commented there this may not work out due to false positives, but maybe we could get it to work. I think that would be cool.
But as for this PR: LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.