-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta-lxatac-bsp: barebox: update to 2024.09.0 #174
Conversation
...cipes-bsp/barebox/files/patches/0103-ARM-stm32mp-add-Linux-Automation-TAC-Generation-3.patch
Show resolved
Hide resolved
+ * Instead drivers are called with the device tree node in action and | ||
+ * instructed to apply it. | ||
+ * | ||
+ * We can add support for this binding for STM32 only as first step, but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this being removed? v2024.08.0 doesn't support the new binding either. I added support recently, but it is slated for inclusion in v2024.10.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the respective fixup!
commits did not make it to the v2024.03.0/customers/lxa/tac
branch or got force pushed away (sounds like something I would do by accident tbh).
I've made sure to push them to v2024.03.0/customers/lxa/tac
again and have also included them in the last update of this PR.
...cipes-bsp/barebox/files/patches/0103-ARM-stm32mp-add-Linux-Automation-TAC-Generation-3.patch
Show resolved
Hide resolved
|
||
+pblb-$(CONFIG_MACH_LXA_TAC) += start_stm32mp15xc_lxa_tac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts e285dad which is likely not intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the respective fixup!
commit did not make it to the v2024.03.0/customers/lxa/tac
branch or got force pushed away (sounds like something I would do by accident tbh).
I've made sure to push it to v2024.03.0/customers/lxa/tac
again and have also included it in the last update of this PR.
@@ -18,7 +18,7 @@ image @IMAGE@fip { | |||
fip { | |||
fw-config = "stm32mp157c-lxa-tac-fw-config.dtb" | |||
hw-config = "stm32mp157c-lxa-tac-fw-config.dtb" | |||
nt-fw = "barebox-stm32mp15xc-lxa-tac.img" | |||
nt-fw = "barebox-stm32mp15xc-lxa-tac.stm32" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .stm32 image contains at 256 byte header that I suspect will be executed as code. The .img omitted that header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. This was a result of me missing the fixup that did the stm32
--> img
transition.
The fixup from e285dad is now back in and this change no longer required.
It looks like I screwed up somewhere while rebasing the changes on top of 2024.08.0. I will have to investigate that a bit. Since we do not need this update in the next stable release, I will change this to a draft PR and investigate once the release is out. |
088b33c
to
acabe63
Compare
I've revisited this PR now and did indeed find a mistake while rebasing - I was missing two fixup commits that changed the image file type and added pull-ups to the button inputs. While at it I also updated to 2024.09 instead of 2024.08. |
Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
acabe63
to
c79e3d5
Compare
Just a routine update.
TODO before merging: