Add security checks based on proxy PID and app ID #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iinuwa
force-pushed
the
push-vsrpuwoxummx
branch
from
f6f5d63 to
2550c20
Compare
msirringhaus
previously approved these changes
Feb 6, 2026
Collaborator
msirringhaus
left a comment
msirringhaus
left a comment
There was a problem hiding this comment.
Just one random thought
| origin: Option<&str>, | ||
| top_origin: Option<&str>, | ||
| ) -> Result<Origin, WebAuthnError> { | ||
| let trusted_clients = [ |
Collaborator
There was a problem hiding this comment.
I wonder if we would want to read this from a config file installed in /etc/ (or /usr/etc/), so that downstream distros, or also admins can add their own clients as trusted.
Member
Author
There was a problem hiding this comment.
Yes, we should. That involves a lot of decisions that I didn't want to get into at the moment. I created #131 to track that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.