Skip to content

Fix #12: Implement proper support for transport and attachment #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iinuwa merged 4 commits into from
Apr 17, 2025
Merged

Fix #12: Implement proper support for transport and attachment #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
879cf54
Run rustfmt on the files about to be changed
msirringhaus Apr 17, 2025
bf797ec
Replace hardcoded transport
msirringhaus Apr 17, 2025
ebda2e8
Run rustfmt on two more files
msirringhaus Apr 17, 2025
2cab0c7
Replace hard-coded attachment modality
msirringhaus Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions webext/add-on/content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ async function cloneCredentialResponse(credential) {
const obj = {}
obj.id = credential.id;
obj.rawId = cloneInto(Uint8Array.fromBase64(credential.rawId, options), obj)
// TODO: get authenticator attachment
obj.authenticatorAttachment = undefined
obj.authenticatorAttachment = credential.authenticatorAttachment;
const response = {}
// credential registration response
if (credential.response.attestationObject) {
Expand Down
Loading