-
-
Notifications
You must be signed in to change notification settings - Fork 198
Bump coreboot to 25.09 #2007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Bump coreboot to 25.09 #2007
Conversation
|
@gaspar-ilom thanks for this contribution! 25.09 seems a good moment to switch all boards depending on previous effort against coreboot master (was 24.12 : YY.MM being 2024.12). That will require all boards coreboot config to be switched with help of helpers (switch to defconfig, make sure what is left there needs overriding over defaults, save back in oldconfig format) and call for testing using testing template and improve upon it, and tagging all known board owners/testers. This PR should supersede other attempts referred in OP. T480s/t480 support under coreboot master justifies it, as well as TB support, if testing results here is reported upstream so that we can guarantee that next coreboot release will include patches applied here on next coreboot version bump. |
ced2f98 to
4854371
Compare
-bump the coreboot version 25.09 for all boards on 24.12 - get rid of libreboot and our own hacky patches for the T480 as this board is now supported upstream - include the unmerged Thunderbolt patches for the T480 from: https://review.coreboot.org/c/coreboot/+/75286/18 and https://review.coreboot.org/c/coreboot/+/88490/1 - keep the patches for PR0 flash protection https://review.coreboot.org/c/coreboot/+/85278 and for clearing tpm log area https://review.coreboot.org/c/coreboot/+/84927/1 Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
for all boards moved from 24.12 to 25.09 execute: ./docker_repro.sh make coreboot.save_in_oldconfig_format_in_place BOARD=XXX no manual sanity checks were executed yet Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
the board is now officially supported by coreboot fix references to t480 flashing instructions. before it pointed to t430. Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
not sure which change made this necessary needs investigation Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
4854371 to
fdeb5e8
Compare
Great!
Not sure I have done what you intended. See commit message of 78451c9 I would only let the testers know when this is done. Testers for boards that use the new coreboot version should be enough, though?!
Let's see what will be reported. |
|
Making this a draft because it is not done yet. See f077ada |
|
Updated the How to proceed section in the OP to reflect what @tlaurion suggested. |
|
@tlaurion CircleCi is beyond me: Why does gaspar-ilom@ced2f98 succeed but EDIT: I undid the revert from fe4e190 as it does not seem to change anything. Local build works, of course 🙄 |
1511136 to
fdeb5e8
Compare
|
@gaspar-ilom i don't make sense of the circleci error, as if cache was partial at https://app.circleci.com/pipelines/github/gaspar-ilom/heads/14/workflows/b282ff7a-03b4-43af-aed1-369e0454906f/jobs/709 This would need to build without cache to succeed if local builds succeed. To do this, under Circleci project setting, variable, change/add CACHE_VERSION with unique value (I do datestamp) or change variable name under Circleci config, ie Line 82 in aaeb63d
|
@tlaurion Thanks for the hint. Trying it here: https://app.circleci.com/pipelines/github/gaspar-ilom/heads/12/workflows/8314619a-fb68-4af8-8915-06abf2a8f93d |
This bumps the coreboot to version 25.09.
Also, it applies the WIP Thunderbolt patches from
Old patches for 24.12 are removed. In particular, the ones we copied from libreboot. However, we might want to keep some which are currently not included such as
The motivation was to get the merged changes for the sky/kaby lake boards such as the T480. Therefore - if merged - this PR would replace #1989 and also require updating #1966
State
How to proceed?