Skip to content

Conversation

@gaspar-ilom
Copy link
Contributor

@gaspar-ilom gaspar-ilom commented Oct 18, 2025

This bumps the coreboot to version 25.09.

Also, it applies the WIP Thunderbolt patches from

Old patches for 24.12 are removed. In particular, the ones we copied from libreboot. However, we might want to keep some which are currently not included such as

  • Remove the stack overflow debug option (was included before)
  • Disable NVME hotplug (not included before). However, I have not encountered the issue. So I would not do it for now.

The motivation was to get the merged changes for the sky/kaby lake boards such as the T480. Therefore - if merged - this PR would replace #1989 and also require updating #1966

State

  • T480 build flashed internally and confirmed working
  • The primary USB-C port keeps working inclduding charging and display port
  • The lower USB-C port also works
    • Nitrokey works, didn't before.
    • Charging and display port
    • In Qubes a USB block device was not detected nor keyboard, mouse etc. Did not investigate
  • Some screen glitches that I had in Qubes OS seem to have disappeared
  • Investigate why f077ada is necessary and decide on a (proper) solution
  • Thunderbolt needs testing.
    • I don't have a suitable device.
  • Implement it cleanly. Rename coreboot 24.12 to 25.09 etc.
    • Currently, it is still a WIP with minimal effort. Will change that if there is a good chance of making it into master.

How to proceed?

  1. Bump the version for all boards on 24.12 to 25.09. DONE.
  2. Keep the Thunderbolt fixes that are not yet merged upstream and report issues there.
  3. Investigate the build issue mentioned above
  4. Let board testers know and ask for testing (incl. TB for T480).

@tlaurion
Copy link
Collaborator

@gaspar-ilom thanks for this contribution!

25.09 seems a good moment to switch all boards depending on previous effort against coreboot master (was 24.12 : YY.MM being 2024.12).

That will require all boards coreboot config to be switched with help of helpers (switch to defconfig, make sure what is left there needs overriding over defaults, save back in oldconfig format) and call for testing using testing template and improve upon it, and tagging all known board owners/testers.

This PR should supersede other attempts referred in OP. T480s/t480 support under coreboot master justifies it, as well as TB support, if testing results here is reported upstream so that we can guarantee that next coreboot release will include patches applied here on next coreboot version bump.

@gaspar-ilom gaspar-ilom force-pushed the coreboot-25-09 branch 4 times, most recently from ced2f98 to 4854371 Compare October 18, 2025 21:06
-bump the coreboot version 25.09 for all boards on 24.12
- get rid of libreboot and our own hacky patches for the T480
as this board is now supported upstream
- include the unmerged Thunderbolt patches for the T480 from:
https://review.coreboot.org/c/coreboot/+/75286/18 and
https://review.coreboot.org/c/coreboot/+/88490/1
- keep the patches for PR0 flash protection
https://review.coreboot.org/c/coreboot/+/85278
and for clearing tpm log area
https://review.coreboot.org/c/coreboot/+/84927/1

Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
for all boards moved from 24.12 to 25.09 execute:
./docker_repro.sh make coreboot.save_in_oldconfig_format_in_place BOARD=XXX
no manual sanity checks were executed yet

Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
the board is now officially supported by coreboot
fix references to t480 flashing instructions. before it pointed to t430.

Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
not sure which change made this necessary

needs investigation

Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
@gaspar-ilom
Copy link
Contributor Author

25.09 seems a good moment to switch all boards depending on previous effort against coreboot master (was 24.12 : YY.MM being 2024.12).

Great!

That will require all boards coreboot config to be switched with help of helpers (switch to defconfig, make sure what is left there needs overriding over defaults, save back in oldconfig format) and call for testing using testing template and improve upon it, and tagging all known board owners/testers.

Not sure I have done what you intended. See commit message of 78451c9

I would only let the testers know when this is done. Testers for boards that use the new coreboot version should be enough, though?!

This PR should supersede other attempts referred in OP. T480s/t480 support under coreboot master justifies it, as well as TB support, if testing results here is reported upstream so that we can guarantee that next coreboot release will include patches applied here on next coreboot version bump.

Let's see what will be reported.

@gaspar-ilom gaspar-ilom marked this pull request as draft October 18, 2025 21:14
@gaspar-ilom
Copy link
Contributor Author

Making this a draft because it is not done yet. See f077ada

@gaspar-ilom
Copy link
Contributor Author

Updated the How to proceed section in the OP to reflect what @tlaurion suggested.

@gaspar-ilom
Copy link
Contributor Author

gaspar-ilom commented Oct 19, 2025

@tlaurion CircleCi is beyond me: Why does gaspar-ilom@ced2f98 succeed but x86-musl-cross-make fails reliably for 78451c9 and fdeb5e8 . The latter is identical to the succeeding gaspar-ilom@ced2f98

EDIT: I undid the revert from fe4e190 as it does not seem to change anything. Local build works, of course 🙄

@tlaurion
Copy link
Collaborator

tlaurion commented Oct 21, 2025

@gaspar-ilom i don't make sense of the circleci error, as if cache was partial at https://app.circleci.com/pipelines/github/gaspar-ilom/heads/14/workflows/b282ff7a-03b4-43af-aed1-369e0454906f/jobs/709

This would need to build without cache to succeed if local builds succeed.

To do this, under Circleci project setting, variable, change/add CACHE_VERSION with unique value (I do datestamp) or change variable name under Circleci config, ie

- nix-docker-heads-modules-and-patches-{{ checksum "./tmpDir/all_modules_and_patches.sha256sums" }}{{ .Environment.CACHE_VERSION }}

@gaspar-ilom
Copy link
Contributor Author

To do this, under Circleci project setting, variable, change/add CACHE_VERSION with unique value (I do datestamp) or change variable name under Circleci config, ie

@tlaurion Thanks for the hint. Trying it here: https://app.circleci.com/pipelines/github/gaspar-ilom/heads/12/workflows/8314619a-fb68-4af8-8915-06abf2a8f93d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants