Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 特化打开搜狗输入法设置页面方式 #44

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

zsien
Copy link
Member

@zsien zsien commented Aug 2, 2024

使用 AM 打开搜狗自己的配置页

Issues: linuxdeepin/developer-center#10079

@zsien zsien requested a review from a team August 2, 2024 03:14
@zsien
Copy link
Member Author

zsien commented Aug 2, 2024

/integrate

Copy link

github-actions bot commented Aug 2, 2024

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#1831
PrNumber: 1831
PrBranch: auto-integration-10209403320

Copy link

github-actions bot commented Aug 2, 2024

TAG Bot

TAG: 5.0.23
EXISTED: no
DISTRIBUTION: unstable

@deepin-bot
Copy link

deepin-bot bot commented Aug 2, 2024

TAG Bot

New tag: 5.0.22
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #42

  * chore: 特化打开搜狗输入法设置页面方式
    Issues: linuxdeepin/developer-center#10079
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在新增代码中,使用了硬编码的字符串,建议使用常量或配置文件来管理这些值。
  • 新增代码中没有处理异常情况,例如DDBusSender的调用可能失败。
  • 新增代码中的QStringLiteral使用了旧式的字符串连接,建议使用QString::fromUtf8或QByteArray::fromUtf8来避免潜在的字符编码问题。

是否建议立即修改:

@zsien
Copy link
Member Author

zsien commented Aug 2, 2024

/integrate

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yixinshark, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zsien zsien merged commit dfe15fa into linuxdeepin:master Aug 2, 2024
9 of 10 checks passed
@zsien zsien deleted the zs/chore/sogou-configure branch August 2, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants